Skip to content

feat: show loader during background effect initialization [WPB-24453]#21441

Merged
zskhan merged 2 commits into
devfrom
feat/show-loader-during-bg-effect-initialization
Jun 9, 2026
Merged

feat: show loader during background effect initialization [WPB-24453]#21441
zskhan merged 2 commits into
devfrom
feat/show-loader-during-bg-effect-initialization

Conversation

@zskhan

@zskhan zskhan commented Jun 4, 2026

Copy link
Copy Markdown
Contributor
BugWPB-24453 Virtual background appears 2 seconds late when the effect is applied.

During the initialization and application of background effect, there will be a spinner displayed to improve the UX

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 15
  • Failed: 0
  • Skipped: 0
  • 🔁 Flaky: 0
  • 📊 Total: 15
  • Total Runtime: 156.8s (~ 2 min 37 sec)

@EnricoSchw EnricoSchw self-requested a review June 5, 2026 06:34
Comment thread apps/webapp/src/script/components/calling/GroupVideoGridTile.tsx Outdated
Comment thread apps/webapp/src/script/components/calling/GroupVideoGridTile.tsx Outdated
Comment thread apps/webapp/src/script/components/calling/GroupVideoGridTile.tsx
@zskhan zskhan requested a review from arjita-mitra June 8, 2026 10:59
@zskhan zskhan force-pushed the feat/show-loader-during-bg-effect-initialization branch from 20550a6 to ffa7848 Compare June 8, 2026 13:44
@zskhan zskhan enabled auto-merge June 8, 2026 14:36
Comment thread apps/webapp/src/script/components/calling/GroupVideoGridTile.tsx
e-maad
e-maad previously approved these changes Jun 8, 2026

@e-maad e-maad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few suggestions.

Comment thread apps/webapp/src/script/components/calling/GroupVideoGridTile.tsx Outdated
Comment thread apps/webapp/src/script/components/calling/useShowLoadingOverlay.ts Outdated
@zskhan zskhan force-pushed the feat/show-loader-during-bg-effect-initialization branch from ffa7848 to 57cd6af Compare June 8, 2026 15:12
@zskhan zskhan requested a review from e-maad June 8, 2026 15:13
@zskhan zskhan force-pushed the feat/show-loader-during-bg-effect-initialization branch from 57cd6af to 548d2de Compare June 9, 2026 09:07
@sonarqubecloud

sonarqubecloud Bot commented Jun 9, 2026

Copy link
Copy Markdown

@zskhan zskhan added this pull request to the merge queue Jun 9, 2026
Merged via the queue into dev with commit 3f90451 Jun 9, 2026
36 checks passed
@zskhan zskhan deleted the feat/show-loader-during-bg-effect-initialization branch June 9, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants